Skip to content

update coverage config #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 23, 2021
Merged

update coverage config #6524

merged 25 commits into from
Mar 23, 2021

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 15, 2021 •
edited
Loading

What does this PR do?

there seem to be some random coverage failers...
reverting back to use base coverage

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration labels Mar 15, 2021
@Borda Borda added this to the 1.2.x milestone Mar 15, 2021
@Borda Borda marked this pull request as draft March 15, 2021 10:44
Borda
Borda commented Mar 15, 2021
View reviewed changes
@Borda Borda marked this pull request as ready for review March 15, 2021 11:56
Borda
Borda commented Mar 15, 2021
View reviewed changes
@Borda Borda added the priority: 1 Medium priority task label Mar 15, 2021
tchaton
tchaton approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda added the ready PRs ready to be merged label Mar 15, 2021
@Borda Borda enabled auto-merge (squash) March 15, 2021 14:21
@mergify mergify bot removed the has conflicts label Mar 15, 2021
@Borda Borda marked this pull request as draft March 15, 2021 16:30
auto-merge was automatically disabled March 15, 2021 16:30

Pull request was converted to draft

@Borda Borda removed the ready PRs ready to be merged label Mar 16, 2021
@Borda Borda force-pushed the ci/coverage branch 2 times, most recently from 8c9f0cd to eb893ff Compare March 20, 2021 10:04
@Borda Borda marked this pull request as ready for review March 23, 2021 21:09
@Borda Borda requested review from a team, rohitgr7, s-rog and yukw777 March 23, 2021 21:11
@Borda Borda added the ready PRs ready to be merged label Mar 23, 2021
@Borda Borda merged commit 64d0fa4 into master Mar 23, 2021
@Borda Borda deleted the ci/coverage branch March 23, 2021 22:05
@carmocca carmocca mentioned this pull request Mar 29, 2021
Closed
carmocca pushed a commit that referenced this pull request Mar 29, 2021
@Borda @carmocca
update coverage config (#6524)
c4f262f 
* update coverage config

* parallel

* parallel

* Apply suggestions from code review

* Apply suggestions from code review

* paralel

* paralel

* paralel

* combine

* combine

* .

* ..

* ..

* ..

* rev

* cb

* cb

* drop

* drop

* .

* ..

* ...

* ...

* ...

* .
Borda added a commit that referenced this pull request Mar 30, 2021
@Borda
update coverage config (#6524)
c02db78 
* update coverage config

* parallel

* parallel

* Apply suggestions from code review

* Apply suggestions from code review

* paralel

* paralel

* paralel

* combine

* combine

* .

* ..

* ..

* ..

* rev

* cb

* cb

* drop

* drop

* .

* ..

* ...

* ...

* ...

* .
lexierule pushed a commit that referenced this pull request Mar 30, 2021
@Borda @lexierule
update coverage config (#6524)
b9aed4a 
* update coverage config

* parallel

* parallel

* Apply suggestions from code review

* Apply suggestions from code review

* paralel

* paralel

* paralel

* combine

* combine

* .

* ..

* ..

* ..

* rev

* cb

* cb

* drop

* drop

* .

* ..

* ...

* ...

* ...

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@s-rog s-rog Awaiting requested review from s-rog

@yukw777 yukw777 Awaiting requested review from yukw777

+1 more reviewer

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.2.x

Development

Successfully merging this pull request may close these issues.

4 participants

@Borda @carmocca @tchaton @SkafteNicki