Skip to content

Conversation

@akihironitta
Copy link
Contributor

What does this PR do?

Follow up of #6294.

This PR makes sure to use:

class Model(pl.LightningModule):
    def __init__(self):
        self.automatic_optimization = False

instead of:

class Model(pl.LightningModule):
    @property
    def automatic_optimization(self):
        return False

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #6373 (d5aeeeb) into master (4f391bc) will decrease coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6373    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         161     161            
  Lines       11464   11464            
=======================================
- Hits        10706   10483   -223     
- Misses        758     981   +223     

@rohitgr7 rohitgr7 enabled auto-merge (squash) March 6, 2021 16:56
@rohitgr7 rohitgr7 added the ready PRs ready to be merged label Mar 6, 2021
@rohitgr7 rohitgr7 merged commit 34b733b into Lightning-AI:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants