Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Mar 2, 2021

What does this PR do?

This PR provides a complete GAN example with manual optimization as requested by some users.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added this to the 1.2.x milestone Mar 2, 2021
@tchaton tchaton self-assigned this Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #6294 (57539ec) into master (49c579f) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6294    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         160     161     +1     
  Lines       11415   11457    +42     
=======================================
- Hits        10644   10416   -228     
- Misses        771    1041   +270     

@tchaton tchaton enabled auto-merge (squash) March 2, 2021 11:10
@Borda Borda added the docs Documentation related label Mar 2, 2021
@Borda Borda modified the milestones: 1.2.x, 1.3 Mar 2, 2021
@Borda Borda requested review from Borda and carmocca March 5, 2021 20:12
@tchaton tchaton merged commit 4f391bc into master Mar 5, 2021
@tchaton tchaton deleted the improve_manual_optimization_doc branch March 5, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants