Accelerator Refactor/RPC + Sharded #5732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-01 11:19:59 UTC |
tchaton
approved these changes
Feb 1, 2021
Contributor
tchaton
left a comment
tchaton
left a comment
There was a problem hiding this comment.
LGTM ! I think we will have to be careful with duplicated code for Plugin as Shared.
Borda
approved these changes
Feb 1, 2021
Collaborator
|
just add chlog :] |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5732 +/- ##
================================================
- Coverage 89% 89% -0%
================================================
Files 173 173
Lines 12495 12339 -156
================================================
- Hits 11171 11007 -164
- Misses 1324 1332 +8 |
awaelchli
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last PR adding new classes for the accelerator refactor (#5616 ).
It should be merged after #5719 .
It adds support for sharded training and RPC/Model parallelism.