-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix pre-commit isort failure on tests/plugins/*.py #5422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit isort failure on tests/plugins/*.py #5422
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ydcjeff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this all changes applied by isort in tests/plugins/* ?
|
@ydcjeff yes |
1e5f312 to
c39ee81
Compare
|
Please first merge #5421 |
|
@arnaudgelas it seems you introduced a cumulative change from other PR, mind keep the change only to files mentioned in the PR, so here it is |
c39ee81 to
40aced2
Compare
3b47dfd to
4b6d196
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5422 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 152 152
Lines 10732 10732
===============================================
Hits 9944 9944
Misses 788 788 |
What does this PR do?
Relates to #4805
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃