Skip to content

Conversation

@arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 8, 2021

What does this PR do?

Relates to #4805

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@arnaudgelas arnaudgelas changed the base branch from master to release/1.2-dev January 8, 2021 16:39
Copy link

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all changes applied by isort in tests/plugins/* ?

@arnaudgelas
Copy link
Contributor Author

@ydcjeff yes

@arnaudgelas arnaudgelas changed the title Fix/isort tests.plugins Fix pre-commit isort failure on tests/plugins/*.py Jan 8, 2021
@Borda Borda added the refactor label Jan 10, 2021
@Borda Borda added this to the 1.2 milestone Jan 10, 2021
@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.plugins branch from 1e5f312 to c39ee81 Compare January 11, 2021 11:19
@arnaudgelas
Copy link
Contributor Author

Please first merge #5421

@Borda Borda enabled auto-merge (squash) January 11, 2021 12:24
@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
@Borda
Copy link
Collaborator

Borda commented Jan 11, 2021

@arnaudgelas it seems you introduced a cumulative change from other PR, mind keep the change only to files mentioned in the PR, so here it is tests/plugins/*.py

@Borda Borda removed the ready PRs ready to be merged label Jan 11, 2021
@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.plugins branch from c39ee81 to 40aced2 Compare January 11, 2021 13:49
@arnaudgelas arnaudgelas disabled auto-merge January 11, 2021 14:21
@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
@Borda Borda enabled auto-merge (squash) January 11, 2021 14:23
@Borda Borda mentioned this pull request Jan 12, 2021
30 tasks
@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.plugins branch from 3b47dfd to 4b6d196 Compare January 14, 2021 08:22
@Borda Borda merged commit 84d1040 into Lightning-AI:release/1.2-dev Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #5422 (4b6d196) into release/1.2-dev (e806bb7) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5422   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  152     152           
  Lines                10732   10732           
===============================================
  Hits                  9944    9944           
  Misses                 788     788           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants