Skip to content

Conversation

@arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 8, 2021

What does this PR do?

Relates to #4805

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5421 (59cb7c0) into release/1.2-dev (d8a0c7d) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5421   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  152     152           
  Lines                10732   10732           
===============================================
  Hits                  9944    9944           
  Misses                 788     788           

@Borda Borda added the refactor label Jan 10, 2021
@Borda Borda added this to the 1.2 milestone Jan 10, 2021
@arnaudgelas arnaudgelas force-pushed the fix/isort-test.trainer branch from 4bd66f7 to 7458354 Compare January 11, 2021 11:17
@arnaudgelas
Copy link
Contributor Author

Please merge first #5420

@arnaudgelas arnaudgelas force-pushed the fix/isort-test.trainer branch 2 times, most recently from ddf78ed to ea4a6f5 Compare January 11, 2021 11:53
@Borda Borda enabled auto-merge (squash) January 11, 2021 12:24
@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
Borda
Borda previously approved these changes Jan 11, 2021
@Borda
Copy link
Collaborator

Borda commented Jan 11, 2021

@arnaudgelas it seems you introduced cumulative change from other PR, mind keep the change only to files mentioned in the PR, so here it is tests/trainer/*.py

@Borda Borda removed the ready PRs ready to be merged label Jan 11, 2021
@Borda
Copy link
Collaborator

Borda commented Jan 11, 2021

Please merge first #5420

pls make the changes independent, there is no reason why it shall be cumulative and we would need to rebase each PR

@arnaudgelas
Copy link
Contributor Author

@Borda Once #5420 gets merged, I will rebase that one.

@arnaudgelas arnaudgelas force-pushed the fix/isort-test.trainer branch from ea4a6f5 to a81e68a Compare January 11, 2021 13:36
@arnaudgelas
Copy link
Contributor Author

@Borda rebased

@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
@arnaudgelas arnaudgelas disabled auto-merge January 11, 2021 13:48
@Borda Borda enabled auto-merge (squash) January 11, 2021 14:31
@arnaudgelas arnaudgelas disabled auto-merge January 11, 2021 14:35
@arnaudgelas
Copy link
Contributor Author

@Borda The 2 commits are atomic and meaningful as such. I don't get why you want to squash them? I though that was one of your requirement, squashing them together is going the other way around, isn't it?

@Borda Borda mentioned this pull request Jan 12, 2021
30 tasks
@Borda Borda enabled auto-merge (squash) January 13, 2021 11:40
@arnaudgelas arnaudgelas force-pushed the fix/isort-test.trainer branch 2 times, most recently from 7691d73 to 71a9c41 Compare January 14, 2021 10:31
@arnaudgelas arnaudgelas force-pushed the fix/isort-test.trainer branch from 71a9c41 to 59cb7c0 Compare January 14, 2021 11:12
@Borda Borda mentioned this pull request Jan 14, 2021
12 tasks
@Borda Borda merged commit 7fb0221 into Lightning-AI:release/1.2-dev Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants