-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix pre-commit isort failure on tests/trainer/*.py #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit isort failure on tests/trainer/*.py #5421
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5421 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 152 152
Lines 10732 10732
===============================================
Hits 9944 9944
Misses 788 788 |
4bd66f7 to
7458354
Compare
|
Please merge first #5420 |
ddf78ed to
ea4a6f5
Compare
|
@arnaudgelas it seems you introduced cumulative change from other PR, mind keep the change only to files mentioned in the PR, so here it is |
pls make the changes independent, there is no reason why it shall be cumulative and we would need to rebase each PR |
ea4a6f5 to
a81e68a
Compare
|
@Borda rebased |
|
@Borda The 2 commits are atomic and meaningful as such. I don't get why you want to squash them? I though that was one of your requirement, squashing them together is going the other way around, isn't it? |
7691d73 to
71a9c41
Compare
71a9c41 to
59cb7c0
Compare
What does this PR do?
Relates to #4805
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃