update PR template #4523
Merged
update PR template #4523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4523 +/- ##
======================================
Coverage 92% 93%
======================================
Files 116 116
Lines 8822 8769 -53
======================================
- Hits 8129 8117 -12
+ Misses 693 652 -41 |
s-rog
reviewed
Nov 5, 2020
Co-authored-by: Roger Shieh <[email protected]>
tchaton
approved these changes
Nov 5, 2020
Contributor
tchaton
left a comment
tchaton
left a comment
There was a problem hiding this comment.
Great. Let's make sure the checklist is validated before merging any PR :)
s-rog
approved these changes
Nov 5, 2020
edenlightning
approved these changes
Nov 5, 2020
Co-authored-by: edenlightning <[email protected]>
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* update PR template * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Roger Shieh <[email protected]> * Apply suggestions from code review Co-authored-by: edenlightning <[email protected]> Co-authored-by: chaton <[email protected]> Co-authored-by: Roger Shieh <[email protected]> Co-authored-by: edenlightning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating PR template with a simple bullet-list and link to the guidelines, discussed with @edenlightning
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃