Skip to content

Commit 62ea461

Browse files
Bordatchatons-rogedenlightning
authored
update PR template (#4523)
* update PR template * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Roger Shieh <[email protected]> * Apply suggestions from code review Co-authored-by: edenlightning <[email protected]> Co-authored-by: chaton <[email protected]> Co-authored-by: Roger Shieh <[email protected]> Co-authored-by: edenlightning <[email protected]>
1 parent 51cc7a8 commit 62ea461

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
Please include a summary of the change and which issue is fixed.
55
Please also include relevant motivation and context.
66
List any dependencies that are required for this change.
7+
8+
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
79
-->
810

911
Fixes # (issue)
@@ -20,10 +22,14 @@ Fixes # (issue)
2022
<!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->
2123

2224
## PR review
23-
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
25+
Anyone in the community is free to review the PR once the tests have passed.
26+
Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:
2427

25-
Anyone in the community is free to review the PR once the tests have passed.
26-
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
28+
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
29+
- [ ] Check that all items from **Before submitting** are resolved
30+
- [ ] Make sure the title is self explanatory and the description concisely explains the PR
31+
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._
32+
2733

2834
## Did you have fun?
2935
Make sure you had fun coding 🙃

0 commit comments

Comments
 (0)