You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+9-3Lines changed: 9 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,6 +4,8 @@
4
4
Please include a summary of the change and which issue is fixed.
5
5
Please also include relevant motivation and context.
6
6
List any dependencies that are required for this change.
7
+
8
+
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
7
9
-->
8
10
9
11
Fixes # (issue)
@@ -20,10 +22,14 @@ Fixes # (issue)
20
22
<!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->
21
23
22
24
## PR review
23
-
-[ ] Is this pull request ready for review? (if not, please submit in draft mode)
25
+
Anyone in the community is free to review the PR once the tests have passed.
26
+
Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:
24
27
25
-
Anyone in the community is free to review the PR once the tests have passed.
26
-
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
28
+
-[ ] Is this pull request ready for review? (if not, please submit in draft mode)
29
+
-[ ] Check that all items from **Before submitting** are resolved
30
+
-[ ] Make sure the title is self explanatory and the description concisely explains the PR
31
+
-[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._
0 commit comments