Skip to content

[Fix] type checker issue with explicit cast of ref_model object #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2020
Merged

[Fix] type checker issue with explicit cast of ref_model object #4457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9681395
Fix type checker issue with explicit cast of ref_model object
SeanNaren Oct 31, 2020
e099d18
Merge branch 'master' into fix/type-checking
SeanNaren Oct 31, 2020
45acf3e
Merge branch 'master' into fix/type-checking
Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pytorch_lightning/trainer/properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import os
from abc import ABC
from argparse import ArgumentParser, Namespace
from typing import List, Optional, Union, Type, TypeVar
from typing import List, Optional, Union, Type, TypeVar, cast

from pytorch_lightning.callbacks import Callback, ProgressBarBase, ModelCheckpoint
from pytorch_lightning.core.lightning import LightningModule
Expand Down Expand Up @@ -154,6 +154,7 @@ def progress_bar_callback(self):
def progress_bar_dict(self) -> dict:
""" Read-only for progress bar metrics. """
ref_model = self.model if not self.data_parallel else self.model.module
ref_model = cast(LightningModule, ref_model)
return dict(**ref_model.get_progress_bar_dict(), **self.logger_connector.progress_bar_metrics)

@property
Expand Down