[Fix] type checker issue with explicit cast of ref_model object #4457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
Borda,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4457 +/- ##
======================================
Coverage 93% 93%
======================================
Files 113 113
Lines 8191 8192 +1
======================================
+ Hits 7623 7624 +1
Misses 568 568 |
SeanNaren
changed the title
rohitgr7
approved these changes
Oct 31, 2020
SkafteNicki
approved these changes
Oct 31, 2020
ydcjeff
approved these changes
Oct 31, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
Co-authored-by: Jeff Yang <[email protected]> (cherry picked from commit 6211fd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type checking is broken on master due to a properties type not being inferred properly:
https://github.com/PyTorchLightning/pytorch-lightning/pull/4453/checks?check_run_id=1335530408
Adds explicit cast in the properties file for type checker to work correctly.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃