[App] Fix import errors for the packages installed by shebang #15996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhsecond
requested review from
awaelchli,
ethanwharris,
lantiga and
tchaton
as code owners
Contributor
for more information, see https://pre-commit.ci
ethanwharris
approved these changes
Dec 9, 2022
Borda
approved these changes
Dec 9, 2022
hhsecond
commented
Dec 9, 2022
added 3 commits
December 9, 2022 18:05
Borda
added a commit
that referenced
this pull request
Dec 9, 2022
* import fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * import fix * move req * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update requirements/app/base.txt * revert * skip doctest * import fix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> (cherry picked from commit 4bdc185)
lexierule
pushed a commit
that referenced
this pull request
Dec 9, 2022
* dependencies * 0.0.4 * CI: hotfix signal if (#15995) signal if (cherry picked from commit 1706ccd) * revert * [App] Fix import errors for the packages installed by shebang (#15996) * import fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * import fix * move req * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update requirements/app/base.txt * revert * skip doctest * import fix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> (cherry picked from commit 4bdc185) Co-authored-by: Sherin Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our
@requiresdecorator for mandating dependencies are not checking dynamically installed packages but only for those already available in python's memory. This doesn't work if you arerequiringa package that's been installed by our shebang-like syntax. And this is the reason whylightning_api_accesspackage being not available was causing all sort of problem after the last release. Python's import mechanism is a bit more extensive though. It actually looks for new package that is installed after the interpreter came live. This PR is a quick patch for that issue withPythonServecomponent@requires([lightning_api_access])Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda