Skip to content

CI: hotfix signal if #15995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

CI: hotfix signal if #15995

merged 1 commit into from
Dec 9, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 9, 2022 •
edited
Loading

What does this PR do?

this shall not run on master, only for release

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@lantiga lantiga merged commit 1706ccd into master Dec 9, 2022
@lantiga lantiga deleted the ci/fix-signal branch December 9, 2022 17:30
Borda added a commit that referenced this pull request Dec 9, 2022
@Borda
CI: hotfix signal if (#15995)
0e7c919 
signal if

(cherry picked from commit 1706ccd)
lexierule pushed a commit that referenced this pull request Dec 9, 2022
@Borda
dependencies (#15994)
db10422 
* dependencies

* 0.0.4

* CI: hotfix signal if (#15995)

signal if

(cherry picked from commit 1706ccd)

* revert

* [App] Fix import errors for the packages installed by shebang (#15996)

* import fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* import fix

* move req

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update requirements/app/base.txt

* revert

* skip doctest

* import fix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
(cherry picked from commit 4bdc185)

Co-authored-by: Sherin Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carmocca carmocca Awaiting requested review from carmocca

1 more reviewer

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borda @akihironitta @lantiga