Remove error when test dataloader used in test #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR.
Comment last updated at 2020-04-15 23:36:15 UTC |
williamFalcon
changed the title
williamFalcon
changed the title
Borda
reviewed
Apr 15, 2020
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
mind to have the new test structure as separate PR...
Contributor
Author
|
@Borda Trail is not intuitive. Please leave as |
Collaborator
ok, we just need to separate and we cannot use work test
so can I have just |
williamFalcon
commented
Apr 15, 2020
Borda
reviewed
Apr 16, 2020
|
|
||
| ### Removed | ||
|
|
||
| - Removed test for no test dataloader in .fit ([#1495](https://github.com/PyTorchLightning/pytorch-lightning/pull/1495)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Removed test for no test dataloader in .fit ([#1495](https://github.com/PyTorchLightning/pytorch-lightning/pull/1495)) | |
| - Removed test for no test dataloader in `.fit()` ([#1495](https://github.com/PyTorchLightning/pytorch-lightning/pull/1495)) |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* remove error when test dataloader used in test * remove error when test dataloader used in test * remove error when test dataloader used in test * remove error when test dataloader used in test * remove error when test dataloader used in test * remove error when test dataloader used in test * fix lost model reference * remove error when test dataloader used in test * fix lost model reference * moved optimizer types * moved optimizer types * moved optimizer types * moved optimizer types * moved optimizer types * moved optimizer types * moved optimizer types * moved optimizer types * added tests for warning * fix lost model reference * fix lost model reference * added tests for warning * added tests for warning * refactoring * refactoring * fix imports * refactoring * fix imports * refactoring * fix tests * fix mnist * flake8 * review Co-authored-by: J. Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we removed test dataloader we forgot to remove the error check
Fixes #1496