Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 4, 2022

What does this PR do?

While reviewing #13603, I discovered that we have an unused protected class method on the LightningModule.
This can be removed, as all parameter collection is handled inside the save_hyperparameters utility function.

Does your PR introduce any breaking changes? If yes, please list them.

No. This was dead code and a protected API.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @akihironitta

@awaelchli awaelchli added this to the pl:1.8 milestone Aug 4, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 4, 2022
@awaelchli awaelchli marked this pull request as ready for review August 4, 2022 12:26
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #14015 (6d018fa) into master (e78bf20) will increase coverage by 15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #14015     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         341      341             
  Lines       26599    26625     +26     
=========================================
+ Hits        16213    20259   +4046     
+ Misses      10386     6366   -4020     

@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 5, 2022 08:23
@awaelchli awaelchli merged commit 3d5c3d2 into master Aug 5, 2022
@awaelchli awaelchli deleted the refactor/remove-dead-code-module branch August 5, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants