Skip to content

Conversation

@jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 11, 2022

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.core.module.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@jxtngx
Copy link
Contributor Author

jxtngx commented Jul 11, 2022

Original errors after removing module from pyproject.toml can be viewed at: https://github.com/JustinGoheen/lightning/blob/lightningmodule/code-quality/type-hints/module_typehint_errors.md

@jxtngx jxtngx changed the title Fix mypy errors attributed to pytorch_lightning/core/module.py Fix mypy errors attributed to pytorch_lightning.core.module.py Jul 11, 2022
@otaj otaj mentioned this pull request Jul 12, 2022
52 tasks
@jxtngx jxtngx marked this pull request as ready for review July 16, 2022 21:58
@jxtngx jxtngx requested a review from Borda as a code owner July 16, 2022 21:58
@carmocca carmocca modified the milestones: all:next, pl:1.8 Aug 9, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but there are some ignores which need some investigation. Will do.

@mergify mergify bot removed the has conflicts label Aug 12, 2022
@jxtngx
Copy link
Contributor Author

jxtngx commented Aug 16, 2022

apologies, I'm no longer able to keep this PR up to date.

@mergify mergify bot removed the has conflicts label Aug 18, 2022
@awaelchli awaelchli requested a review from rohitgr7 August 18, 2022 14:33
@awaelchli
Copy link
Contributor

apologies, I'm no longer able to keep this PR up to date.

No worries, I will address reviews and finish it. There shouldn't be too much work left here.
@rohitgr7 @carmocca

@mergify mergify bot added the ready PRs ready to be merged label Aug 18, 2022
@awaelchli awaelchli merged commit 090bbc8 into Lightning-AI:master Aug 19, 2022
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
)



Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants