-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy errors attributed to pytorch_lightning.core.module.py
#13603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy errors attributed to pytorch_lightning.core.module.py
#13603
Conversation
|
Original errors after removing module from pyproject.toml can be viewed at: https://github.com/JustinGoheen/lightning/blob/lightningmodule/code-quality/type-hints/module_typehint_errors.md |
pytorch_lightning/core/module.pypytorch_lightning.core.module.py
these are associated with LightningModule
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but there are some ignores which need some investigation. Will do.
|
apologies, I'm no longer able to keep this PR up to date. |
This reverts commit dc76adc.
) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Fix mypy errors attributed to
pytorch_lightning.core.module.pyfor issue #13445Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: