Skip to content

Conversation

@donlapark
Copy link
Contributor

@donlapark donlapark commented Jul 26, 2022

What does this PR do?

This is a follow-up of #13685 which originated from #13445. There is a couple of suggestions by @carmocca that improve the typing of stochastic_weight_avg.py.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

This is a follow-up of #13685 which originated from #13445. There is a couple of suggestions @carmocca that improves the typing of `stochastic_weight_avg.py`.
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@otaj otaj mentioned this pull request Jul 26, 2022
52 tasks
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💜

@carmocca carmocca self-assigned this Jul 26, 2022
@carmocca carmocca added code quality community This PR is from the community labels Jul 26, 2022
@carmocca carmocca added this to the pl:1.8 milestone Jul 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2022
@otaj otaj enabled auto-merge (squash) July 27, 2022 08:17
@otaj otaj merged commit a37fc72 into Lightning-AI:master Jul 27, 2022
@carmocca carmocca modified the milestones: pl:1.8, pl:1.7 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants