Skip to content

fixes typing in stochastic_weight_avg.py (follow-up of #13685) #13860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022
Merged

fixes typing in stochastic_weight_avg.py (follow-up of #13685) #13860

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
103917c
fixes typing in stochastic_weight_avg.py (follow-up of #13685)
donlapark Jul 26, 2022
9d62d8c
Minor
donlapark Jul 26, 2022
7438e9f
Minor
donlapark Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/pytorch_lightning/callbacks/stochastic_weight_avg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def on_train_epoch_start(self, trainer: "pl.Trainer", pl_module: "pl.LightningMo
for lr, group in zip(self._swa_lrs, optimizer.param_groups):
group["initial_lr"] = lr

self._swa_scheduler: _LRScheduler = cast(
self._swa_scheduler = cast(
_LRScheduler,
SWALR(
optimizer,
Expand Down Expand Up @@ -244,19 +244,22 @@ def reset_batch_norm_and_save_state(self, pl_module: "pl.LightningModule") -> No
for module in pl_module.modules():
if not isinstance(module, nn.modules.batchnorm._BatchNorm):
continue
assert module.running_mean is not None
module.running_mean = torch.zeros_like(
module.running_mean, # type: ignore[arg-type]
module.running_mean,
device=pl_module.device,
dtype=module.running_mean.dtype, # type: ignore[union-attr]
dtype=module.running_mean.dtype,
)
assert module.running_var is not None
module.running_var = torch.ones_like(
module.running_var, # type: ignore[arg-type]
module.running_var,
device=pl_module.device,
dtype=module.running_var.dtype, # type: ignore[union-attr]
dtype=module.running_var.dtype,
)
self.momenta[module] = module.momentum
module.momentum = None # type: ignore[assignment]
module.num_batches_tracked *= 0 # type: ignore[assignment, operator]
module.momentum = float()
assert module.num_batches_tracked is not None
module.num_batches_tracked *= 0

def reset_momenta(self) -> None:
"""Adapted from https://github.com/pytorch/pytorch/blob/v1.7.1/torch/optim/swa_utils.py#L164-L165."""
Expand Down