Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 26, 2022

What does this PR do?

Needed for #11098

The batch size for the standalone tests so far was hardcoded. This PR exposes it as a script argument while keeping the hardcoded value as the default.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @akihironitta @Borda

@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@awaelchli awaelchli added ci Continuous Integration and removed pl Generic label for PyTorch Lightning package labels Jul 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2022
@awaelchli awaelchli enabled auto-merge (squash) July 27, 2022 10:53
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13841 (e6c5010) into master (c391170) will decrease coverage by 10%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #13841     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         332      332             
  Lines       26049    26214    +165     
=========================================
- Hits        22328    19860   -2468     
- Misses       3721     6354   +2633     

@awaelchli awaelchli merged commit 2a24b90 into master Jul 27, 2022
@awaelchli awaelchli deleted the ci/standalone-batch-size branch July 27, 2022 12:36
@awaelchli awaelchli mentioned this pull request Jul 27, 2022
11 tasks
@awaelchli awaelchli modified the milestones: pl:1.6.x, pl:1.7 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants