-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Improvements to standalone scripts #13840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
carmocca
approved these changes
Jul 26, 2022
Contributor
|
We use the |
Co-authored-by: Carlos Mocholí <[email protected]>
Contributor
|
#11098 was merged before, but I would still merge the small improvements here. |
kaushikb11
approved these changes
Jul 28, 2022
rohitgr7
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small improvements as a follow up to #11098
In #13841 I introduced the batch size argument for the standalone script, which worked fine for the CI but unfortunately it also broke the following use case, which is handy for locally debugging:
I'm reverting this back to an environment variable because the argument parsing in bash would otherwise get a bit too nasty.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @carmocca @akihironitta @Borda @justusschock @awaelchli @rohitgr7