Skip to content

Conversation

@mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Jul 23, 2022

What does this PR do?

With the latest release of jsonargparse, signature parameters can now be resolved from kwargs.get() statements (see profilers/pytorch.py#L289). This makes test_pytorch_profiler_init_args fail, so this pull request updates the test to avoid failures.

Also some comments were added to better understand what is being tested in parameter resolving. And the minimum jsonargparse version was bumped because anyway it is needed to resolve #13689 (comment).

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 23, 2022
@mauvilsa mauvilsa marked this pull request as ready for review July 23, 2022 08:41
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #13805 (9479a0f) into master (81f149e) will decrease coverage by 9%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13805     +/-   ##
=========================================
- Coverage      86%      76%     -9%     
=========================================
  Files         328      328             
  Lines       25600    25600             
=========================================
- Hits        21933    19559   -2374     
- Misses       3667     6041   +2374     

@akihironitta akihironitta added lightningcli pl.cli.LightningCLI tests labels Jul 23, 2022
@carmocca carmocca added this to the pl:1.7 milestone Jul 23, 2022
@jxtngx jxtngx mentioned this pull request Jul 23, 2022
52 tasks
mauvilsa and others added 3 commits July 23, 2022 14:59
…ble to resolve "record_shapes").

- Added some comments to better understand what is being tested in parameter resolving.
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 23, 2022
@carmocca carmocca enabled auto-merge (squash) July 23, 2022 15:56
@carmocca carmocca merged commit 1b31039 into Lightning-AI:master Jul 25, 2022
@mauvilsa mauvilsa deleted the cli-update-tests branch July 25, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants