-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy errors attributed to pytorch_lightning.loggers.comet
#13689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated additional loggers to create consistent annotations for metrics as Dict[str, Union[Tensor, float]]
jxtngx
commented
Jul 17, 2022
jxtngx
commented
Jul 17, 2022
12 tasks
otaj
approved these changes
Jul 18, 2022
awaelchli
approved these changes
Jul 18, 2022
rohitgr7
approved these changes
Jul 18, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
carmocca
approved these changes
Jul 18, 2022
Borda
approved these changes
Jul 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #13689 +/- ##
=========================================
- Coverage 86% 76% -9%
=========================================
Files 328 328
Lines 25600 25601 +1
=========================================
- Hits 21933 19560 -2373
- Misses 3667 6041 +2374 |
auto-merge was automatically disabled
July 22, 2022 22:18
Head branch was pushed to by a user without write access
awaelchli
reviewed
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
community
This PR is from the community
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix mypy errors attributed to
pytorch_lightning.loggers.cometfor issue #13445Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: