Skip to content

Conversation

@jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 17, 2022

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.loggers.comet for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

jxtngx added 2 commits July 16, 2022 21:25
updated additional loggers to create consistent annotations for metrics as Dict[str, Union[Tensor, float]]
@otaj otaj added this to the pl:1.7 milestone Jul 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 18, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) July 18, 2022 17:22
@carmocca carmocca added the community This PR is from the community label Jul 19, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #13689 (d55367a) into master (1b31039) will decrease coverage by 9%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13689     +/-   ##
=========================================
- Coverage      86%      76%     -9%     
=========================================
  Files         328      328             
  Lines       25600    25601      +1     
=========================================
- Hits        21933    19560   -2373     
- Misses       3667     6041   +2374     

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 21, 2022
auto-merge was automatically disabled July 22, 2022 22:18

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) July 22, 2022 22:38
auto-merge was automatically disabled July 25, 2022 09:25

Pull request was closed

@carmocca carmocca reopened this Jul 25, 2022
@carmocca carmocca enabled auto-merge (squash) July 25, 2022 09:50
@carmocca carmocca merged commit 4e9fbdb into Lightning-AI:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants