Skip to content

Conversation

@shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented Jul 11, 2022

What does this PR do?

Part of #12521

resolves #9118

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@shenoynikhil shenoynikhil changed the title Removed add_to_queue and remove_from_queue from LightningModule Remove add_to_queue and remove_from_queue from LightningModule Jul 11, 2022
@shenoynikhil
Copy link
Contributor Author

@akihironitta Can you have a look at this? Also sorry for the delay.

@rohitgr7 rohitgr7 added breaking change Includes a breaking change community This PR is from the community labels Jul 12, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7 milestone Jul 12, 2022
@carmocca carmocca enabled auto-merge (squash) July 12, 2022 10:59
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta Can you have a look at this? Also sorry for the delay.

No worries! I'm sorry if I rushed you in any way. I just wanted to make sure that breaking changes like this wouldn't be made at the very last minute before the next 1.7 release :)

Thank you again for your contribution, @shenoynikhil!

@carmocca carmocca merged commit e034cd3 into Lightning-AI:master Jul 12, 2022
@shenoynikhil shenoynikhil deleted the shenoynikhil/remove-add-to-queue branch July 12, 2022 15:57
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change community This PR is from the community ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants