-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove add_to_queue and remove_from_queue from LightningModule
#13600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove add_to_queue and remove_from_queue from LightningModule
#13600
Conversation
add_to_queue and remove_from_queue from LightningModuleadd_to_queue and remove_from_queue from LightningModule
|
@akihironitta Can you have a look at this? Also sorry for the delay. |
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihironitta Can you have a look at this? Also sorry for the delay.
No worries! I'm sorry if I rushed you in any way. I just wanted to make sure that breaking changes like this wouldn't be made at the very last minute before the next 1.7 release :)
Thank you again for your contribution, @shenoynikhil!
…ightning-AI#13600) Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Part of #12521
resolves #9118
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃