Skip to content

Conversation

@kingjuno
Copy link
Contributor

@kingjuno kingjuno commented May 11, 2022

What does this PR do?

This PR removes the LightningModule.on_val_dataloader. Following edits happen,
docs/source/common/lightning_module.rst
docs/source/data/datamodule.rst
pytorch_lightning/core/hooks.py
pytorch_lightning/trainer/configuration_validator.py
pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py
tests/deprecated_api/test_remove_1-7.py
tests/models/test_hooks.py
tests/trainer/logging_/test_logger_connector.py

Fixes Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Nil

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added breaking change Includes a breaking change lightningmodule pl.LightningModule community This PR is from the community labels May 11, 2022
@akihironitta akihironitta added this to the 1.7 milestone May 11, 2022
@kingjuno kingjuno marked this pull request as ready for review May 11, 2022 12:12
@kingjuno
Copy link
Contributor Author

@akihironitta Can you please review this?
Also, I see some tests failed. Is it some issue from my side?

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the checkpoint callback changes out of this PR. Otherwise LGTM! Thanks for working on this @kingjuno

@rohitgr7 rohitgr7 force-pushed the remove-LightningModule.on_val_loader branch from 23a87be to 5ae509c Compare May 11, 2022 14:57
@carmocca carmocca changed the title Remove the deprecated LightningModule.on_val_dataloader Remove the deprecated on_{train,val,test,predict}_dataloader hooks May 11, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the other on_*_dataloader hooks in this PR because it was much easier for fixing the tests.

@mergify mergify bot added the ready PRs ready to be merged label May 11, 2022
@carmocca carmocca enabled auto-merge (squash) May 11, 2022 19:55
@carmocca carmocca merged commit 5ab9d53 into Lightning-AI:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change community This PR is from the community lightningmodule pl.LightningModule ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants