-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove the deprecated on_{train,val,test,predict}_dataloader hooks
#13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated on_{train,val,test,predict}_dataloader hooks
#13033
Conversation
|
@akihironitta Can you please review this? |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the checkpoint callback changes out of this PR. Otherwise LGTM! Thanks for working on this @kingjuno
23a87be to
5ae509c
Compare
LightningModule.on_val_dataloaderon_{train,val,test,predict}_dataloader hooks
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the other on_*_dataloader hooks in this PR because it was much easier for fixing the tests.
What does this PR do?
This PR removes the LightningModule.on_val_dataloader. Following edits happen,
docs/source/common/lightning_module.rst
docs/source/data/datamodule.rst
pytorch_lightning/core/hooks.py
pytorch_lightning/trainer/configuration_validator.py
pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py
tests/deprecated_api/test_remove_1-7.py
tests/models/test_hooks.py
tests/trainer/logging_/test_logger_connector.py
Fixes Part of #12521
Does your PR introduce any breaking changes? If yes, please list them.
Nil
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃