Skip to content

Conversation

@shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented May 10, 2022

Part of #12521

What does this PR do?

This PR removes the checkpoint_callback flag from the Trainer Class. Following edits happen,

  • pytorch_lightning/trainer/trainer.py
  • pytorch_lightning/trainer/connectors/callback_connector.py
  • CHANGELOG
  • removed test from tests/deprecated_api/test_remove_1-7.py
  • updated line from simple_classif_training.py

Does your PR introduce any breaking changes? If yes, please list them.

- Trainer(checkpoint_callback=False)
+ Trainer(enable_checkpointing=False)

resolves #9754

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@shenoynikhil shenoynikhil changed the title Removed lines pertinent to checkpoint_callback [WIP] Removing Deprecated checkpoint_callback flag in Trainer May 10, 2022
@shenoynikhil
Copy link
Contributor Author

Dependence in Other Important Repostories

Based on @kaushikb11, I did a search on grep.app and found multiple important examples from

@shenoynikhil
Copy link
Contributor Author

@akihironitta This is my first contribution to PL, let me know if I have missed something obvious :).

@shenoynikhil shenoynikhil marked this pull request as ready for review May 10, 2022 18:02
@akihironitta akihironitta added breaking change Includes a breaking change trainer: argument labels May 10, 2022
@akihironitta akihironitta self-assigned this May 10, 2022
@akihironitta akihironitta added the community This PR is from the community label May 10, 2022
@akihironitta akihironitta added this to the 1.7 milestone May 10, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM!

@akihironitta akihironitta changed the title [WIP] Removing Deprecated checkpoint_callback flag in Trainer Removing Deprecated checkpoint_callback flag in Trainer May 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 10, 2022
@akihironitta akihironitta changed the title Removing Deprecated checkpoint_callback flag in Trainer Remove deprecated checkpoint_callback flag in Trainer May 11, 2022
@akihironitta akihironitta enabled auto-merge (squash) May 11, 2022 08:40
@akihironitta akihironitta merged commit b7959e3 into Lightning-AI:master May 11, 2022
@shenoynikhil shenoynikhil deleted the trainer-remove-ckpt-callback branch May 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change community This PR is from the community ready PRs ready to be merged trainer: argument

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants