Skip to content

Conversation

@puhuk
Copy link
Contributor

@puhuk puhuk commented Apr 7, 2022

To resolve issue #12521

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the has conflicts label Apr 7, 2022
@awaelchli awaelchli added breaking change Includes a breaking change logging Related to the `LoggerConnector` and `log()` labels Apr 9, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 9, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 9, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 10, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 11, 2022
@carmocca carmocca enabled auto-merge (squash) April 11, 2022 16:35
@carmocca carmocca merged commit a86ef06 into Lightning-AI:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants