Skip to content

Conversation

@tkonopka
Copy link
Contributor

@tkonopka tkonopka commented Apr 6, 2022

What does this PR do?

Part of #12521

resolves #8343

Primary change:

  • removed the deprecated model_size property/method from the LightningModule class

Associated edits:

  • removed "model_size" from an internal list of __jit_unused_properties__
  • removed an import made redundant by the above edits
  • removed a unit test associated with the removed method
  • removed a few lines of documentation describing the removed method
  • updated the changelog

Notes:

Following a suggestion from @kaushikb11 in one of the comments in #12521, a search for ".model_size" on grep.app gave 438 hits. This pattern is quite generic, so it is not surprising there are many hits not related to lightning or to this PR. I browsed through them, quickly omitting cases attempting to assign a model size rather than retrieve it and cases where a model size was compared to strings. I investigated the others for signs of importing lightning or including lightning in the repo requirements file. The only proper hit I found was a repository intel-analytics/BigDL. The authors seem to be already aware that the model_size property is deprecated (see here), so no further action taken.

Does your PR introduce any breaking changes? If yes, please list them.

  • removed property model_size in the LightningModule class

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the ready PRs ready to be merged label Apr 6, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) April 6, 2022 17:20
@akihironitta akihironitta added breaking change Includes a breaking change lightningmodule pl.LightningModule labels Apr 7, 2022
@akihironitta akihironitta added this to the 1.7 milestone Apr 7, 2022
@rohitgr7 rohitgr7 merged commit fcea720 into Lightning-AI:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change lightningmodule pl.LightningModule ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate the model_size property on the LightningModule

7 participants