-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Rename Strategy.lr_schedulers to Strategy.lr_scheduler_configs
#11549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lr_schedulers to lr_scheduler_configsStrategy.lr_schedulers to Strategy.lr_scheduler_configs
Codecov Report
@@ Coverage Diff @@
## master #11549 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 194 194
Lines 16947 16947
========================================
- Hits 15562 14948 -614
- Misses 1385 1999 +614 |
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'd say we should add this to the CHANGELOG as "Changed"
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any depreciation via property?
What does this PR do?
Addresses #11443 (comment)
No need to update the changelog since strategy hasn't been released yet?
Does your PR introduce any breaking changes? If yes, please list them.
Strategy.lr_schedulersis renamed toStrategy.lr_scheduler_configs.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @rohitgr7 @akihironitta