Skip to content

Commit e310573

Browse files
committed
Rename local vars
1 parent ec0de6d commit e310573

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

pytorch_lightning/core/optimizer.py

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -184,14 +184,14 @@ def _init_optimizers_and_lr_schedulers(
184184
optim_conf = _MockOptimizer()
185185

186186
optimizers, lr_schedulers, optimizer_frequencies, monitor = _configure_optimizers(optim_conf)
187-
lr_schedulers = (
187+
lr_scheduler_configs = (
188188
_configure_schedulers_automatic_opt(lr_schedulers, monitor)
189189
if model.automatic_optimization
190190
else _configure_schedulers_manual_opt(lr_schedulers)
191191
)
192-
_set_scheduler_opt_idx(optimizers, lr_schedulers)
193-
_validate_scheduler_api(lr_schedulers, model)
194-
return optimizers, lr_schedulers, optimizer_frequencies
192+
_set_scheduler_opt_idx(optimizers, lr_scheduler_configs)
193+
_validate_scheduler_api(lr_scheduler_configs, model)
194+
return optimizers, lr_scheduler_configs, optimizer_frequencies
195195

196196

197197
def _configure_optimizers(
@@ -259,8 +259,9 @@ def _configure_optimizers(
259259

260260

261261
def _configure_schedulers_automatic_opt(schedulers: list, monitor: Optional[str]) -> List[LRSchedulerConfig]:
262-
"""Convert each scheduler into dict structure with relevant information, when using automatic optimization."""
263-
lr_schedulers = []
262+
"""Convert each scheduler into `LRSchedulerConfig` with relevant information, when using automatic
263+
optimization."""
264+
lr_scheduler_configs = []
264265
for scheduler in schedulers:
265266
if isinstance(scheduler, dict):
266267
# check provided keys
@@ -296,24 +297,25 @@ def _configure_schedulers_automatic_opt(schedulers: list, monitor: Optional[str]
296297
" Are you sure you didn't mean 'interval': 'step'?",
297298
category=RuntimeWarning,
298299
)
299-
scheduler = LRSchedulerConfig(**scheduler)
300+
config = LRSchedulerConfig(**scheduler)
300301
elif isinstance(scheduler, ReduceLROnPlateau):
301302
if monitor is None:
302303
raise MisconfigurationException(
303304
"`configure_optimizers` must include a monitor when a `ReduceLROnPlateau`"
304305
" scheduler is used. For example:"
305306
' {"optimizer": optimizer, "lr_scheduler": scheduler, "monitor": "metric_to_track"}'
306307
)
307-
scheduler = LRSchedulerConfig(scheduler, reduce_on_plateau=True, monitor=monitor)
308+
config = LRSchedulerConfig(scheduler, reduce_on_plateau=True, monitor=monitor)
308309
else:
309-
scheduler = LRSchedulerConfig(scheduler)
310-
lr_schedulers.append(scheduler)
311-
return lr_schedulers
310+
config = LRSchedulerConfig(scheduler)
311+
lr_scheduler_configs.append(config)
312+
return lr_scheduler_configs
312313

313314

314315
def _configure_schedulers_manual_opt(schedulers: list) -> List[LRSchedulerConfig]:
315-
"""Convert each scheduler into dict structure with relevant information, when using manual optimization."""
316-
lr_schedulers = []
316+
"""Convert each scheduler into `LRSchedulerConfig` structure with relevant information, when using manual
317+
optimization."""
318+
lr_scheduler_configs = []
317319
for scheduler in schedulers:
318320
if isinstance(scheduler, dict):
319321
invalid_keys = {"interval", "frequency", "reduce_on_plateau", "monitor", "strict"}
@@ -326,15 +328,15 @@ def _configure_schedulers_manual_opt(schedulers: list) -> List[LRSchedulerConfig
326328
category=RuntimeWarning,
327329
)
328330

329-
scheduler = LRSchedulerConfig(**{key: scheduler[key] for key in scheduler if key not in invalid_keys})
331+
config = LRSchedulerConfig(**{key: scheduler[key] for key in scheduler if key not in invalid_keys})
330332
else:
331-
scheduler = LRSchedulerConfig(scheduler)
332-
lr_schedulers.append(scheduler)
333-
return lr_schedulers
333+
config = LRSchedulerConfig(scheduler)
334+
lr_scheduler_configs.append(config)
335+
return lr_scheduler_configs
334336

335337

336-
def _validate_scheduler_api(lr_schedulers: List[LRSchedulerConfig], model: "pl.LightningModule") -> None:
337-
for config in lr_schedulers:
338+
def _validate_scheduler_api(lr_scheduler_configs: List[LRSchedulerConfig], model: "pl.LightningModule") -> None:
339+
for config in lr_scheduler_configs:
338340
scheduler = config.scheduler
339341
if not isinstance(scheduler, _SupportsStateDict):
340342
raise TypeError(

0 commit comments

Comments
 (0)