Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 17, 2022

What does this PR do?

Part of #7037

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @ninginthecloud

@carmocca carmocca added data handling Generic data-related topic code quality labels Jan 17, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 17, 2022
@carmocca carmocca self-assigned this Jan 17, 2022
@carmocca carmocca mentioned this pull request Jan 17, 2022
8 tasks
@carmocca carmocca changed the base branch from master to refactor/fetching_function January 17, 2022 21:19
Base automatically changed from refactor/fetching_function to master January 20, 2022 19:07
@mergify mergify bot added the ready PRs ready to be merged label Jan 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 79a3ff6 into master Feb 2, 2022
@carmocca carmocca deleted the typing/fetching branch February 2, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality data handling Generic data-related topic ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants