Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 17, 2022

What does this PR do?

The previous implementations had some code smells. This PR simplifies it.

Part of #11515

Does your PR introduce any breaking changes? If yes, please list them.

None user-facing

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @ninginthecloud

@carmocca carmocca added refactor data handling Generic data-related topic labels Jan 17, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 17, 2022
@carmocca carmocca self-assigned this Jan 17, 2022
@carmocca carmocca requested a review from justusschock January 18, 2022 15:40
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@mergify mergify bot added the ready PRs ready to be merged label Jan 20, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment

@carmocca carmocca enabled auto-merge (squash) January 20, 2022 18:33
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #11516 (829db52) into master (d50b48e) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #11516    +/-   ##
========================================
  Coverage      92%      92%            
========================================
  Files         194      194            
  Lines       16975    17751   +776     
========================================
+ Hits        15614    16389   +775     
- Misses       1361     1362     +1     

@carmocca carmocca merged commit 5ad5ba5 into master Jan 20, 2022
@carmocca carmocca deleted the refactor/fetching_function branch January 20, 2022 19:07
@carmocca carmocca mentioned this pull request Jan 25, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data handling Generic data-related topic ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants