Skip to content

Conversation

@soullivaneuh
Copy link
Contributor

No description provided.

@stof
Copy link
Contributor

stof commented Oct 8, 2015

you may want to enable a few more rules too

@soullivaneuh
Copy link
Contributor Author

you may want to enable a few more rules too

I agree, but I prefer @cursedcoder decision for that.

@cursedcoder
Copy link
Contributor

you are right @soullivaneuh,
if you mind add please fixes for failing style-ci too

@GrahamCampbell
Copy link
Contributor

You can download the diff StyleCI gives you and apply with with git apply. :)

@soullivaneuh
Copy link
Contributor Author

@cursedcoder It's done.

You can download the diff StyleCI gives you and apply with with git apply. :)

You should add this tip on each analysis on your platform. ;-)

@GrahamCampbell
Copy link
Contributor

Well, normally, you'd be able to have StyleCI create a PR, but it can't do that when the commit was made on a fork.

@soullivaneuh
Copy link
Contributor Author

Well, normally, you'd be able to have StyleCI create a PR, but it can't do that when the commit was made on a fork.

So the tip has his place here. :-)

@GrahamCampbell
Copy link
Contributor

Yeh. I guess. I'll add it at some point, lol. :)

cursedcoder added a commit that referenced this pull request Oct 11, 2015
@cursedcoder cursedcoder merged commit d246707 into KnpLabs:master Oct 11, 2015
@soullivaneuh soullivaneuh deleted the patch-1 branch October 11, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants