Add rate limit endpoint #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Github/Api/RateLimit.php
Outdated
Contributor
There was a problem hiding this comment.
this looks weird. The other methods tell me that this returns an array.
Contributor
Author
There was a problem hiding this comment.
Ah, phpstrom thought for me on that one, will update to array.
Contributor
Author
|
Sorry for all the style fix commits... kept missing extra lines. |
Contributor
|
👍 |
Contributor
|
your new doc page needs to be linked from other doc page (probably the doc index in this case) |
Contributor
Author
|
@stof Good catch, i added the link to the readme. |
lib/Github/Api/RateLimit.php
Outdated
Contributor
There was a problem hiding this comment.
please separate return statement with 1 blank line
Contributor
There was a problem hiding this comment.
You should use symfony preset on your StyleCI config file or at least, add the return fixer.
Contributor
|
@quickliketurtle very good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added the rate_limit endpoint. With the default response, as well as 2 helpers for core rate limit and search rate limit.
I updated Client.php to allow both rateLimit and rate_limit options.
I've added a Test with the sample rate_limit response from github, as well as a functional test ( the functional group is excluded now, but you can run the single file manually and it passes ).
Also added a doc page.
Let me know if there are changed needed. I tried to follow style and naming convention by looking at existing code.
Thanks.