This repository was archived by the owner on May 4, 2019. It is now read-only.
Efficient sorting of DataArrays #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #92, and also speeds up sorting generally, since we avoid type instability. It also includes a change that places NAs at the end instead of the beginning of a sorted array, consistent with the way Base sorts NaN values.
simonster
added a commit
that referenced
this pull request
Jul 10, 2014
Efficient sorting of DataArrays
|
The NA change mentioned here breaks these pda-da sorting comparisons in the DataFrames tests. What do you think about doing the same for pooled data arrays? |
This was referenced Jul 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #92, and also speeds up sorting generally, since we avoid type instability. It also includes a change that places NAs at the end instead of the beginning of a sorted array, consistent with the way
Base sorts NaN values.