`sort` broken on DataArrays

[kmsquire]

Seems to work fine up to length 21, but breaks when the length is 22 or greater:

julia> da = DataArray([ "Catch-60674" 
        "Solexa-13714"
        "Solexa-17327"
        "Catch-61841" 
        "Solexa-17131"
        "Solexa-17325"
        "Catch-70105" 
        "Catch-59134" 
        "Catch-61145" 
        "Solexa-19288"
        "Solexa-17697"
        "Catch-61194" 
        "Catch-139655"
        "Solexa-16321"
        "Catch-60662" 
        "Solexa-17670"
        "Catch-59168" 
        "Solexa-19304"
        "Solexa-19340"
        "Catch-61214" 
        "Catch-70122" 
        "Solexa-16332"
       ]);

julia> all(sort(unique(sort(unique(da[1:21])))) .== sort(unique(da[1:21])))
true

julia> all(sort(unique(sort(unique(da[1:22])))) .== sort(unique(da[1:22])))
false

julia> sort(da[1:21])
21-element ASCIIString DataArray:
 "Catch-139655"
 "Catch-59134" 
 "Catch-59168" 
 "Catch-60662" 
 "Catch-60674" 
 "Catch-61145" 
 "Catch-61194" 
 "Catch-61214" 
 "Catch-61841" 
 "Catch-70105" 
 "Catch-70122" 
 "Solexa-13714"
 "Solexa-16321"
 "Solexa-17131"
 "Solexa-17325"
 "Solexa-17327"
 "Solexa-17670"
 "Solexa-17697"
 "Solexa-19288"
 "Solexa-19304"
 "Solexa-19340"

julia> sort(da) # == sort(da[1:22])
22-element ASCIIString DataArray:
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-139655"
 "Catch-59168" 
 "Catch-60662" 
 "Catch-61194" 
 "Catch-61214" 
 "Catch-70122" 
 "Solexa-16321"
 "Solexa-16332"
 "Solexa-17670"
 "Solexa-19304"
 "Solexa-19340"

[kmsquire]

BTW, this calls the main sort code and works fine for normal arrays:

julia> @which sort(da[1:22])
sort(v::AbstractArray{T,1}) at sort.jl:274

julia> sort([da[1:22]...])
22-element ASCIIString Array:
 "Catch-139655"
 "Catch-59134" 
 "Catch-59168" 
 "Catch-60662" 
 "Catch-60674" 
 "Catch-61145" 
 "Catch-61194" 
 "Catch-61214" 
 "Catch-61841" 
 "Catch-70105" 
 "Catch-70122" 
 "Solexa-13714"
 "Solexa-16321"
 "Solexa-16332"
 "Solexa-17131"
 "Solexa-17325"
 "Solexa-17327"
 "Solexa-17670"
 "Solexa-17697"
 "Solexa-19288"
 "Solexa-19304"
 "Solexa-19340"

[ViralBShah]

I believe you fixed this in julialang/julia.

[kmsquire]

Nope, the issue is still there. I'm glad you commented, though--I had forgotten about this! I'll put it on my todo list to figure out what's happening.

[simonster]

I overhauled sorting in JuliaStats/DataArrays.jl#102. This appears to work fine now.