Add depwarns (but do not remove) the managers that are not currently being maintained (SGE, PBS, HTCondor, and Scyld)
#247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/deprecate-unsupported-managers
branch
from
5903052 to
446f970
Compare
1 task
DilumAluthge
force-pushed
the
dpa/deprecate-unsupported-managers
branch
from
446f970 to
14fbe35
Compare
DilumAluthge
force-pushed
the
dpa/deprecate-unsupported-managers
branch
from
14fbe35 to
9808d41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 39.24% 37.62% -1.62%
==========================================
Files 7 7
Lines 372 388 +16
==========================================
Hits 146 146
- Misses 226 242 +16 ☔ View full report in Codecov by Sentry. |
DilumAluthge
added a commit
that referenced
this pull request
Feb 10, 2025
The SGE functionality in this package is not currently being maintained, so I don't think we should present the SGE docs up-front in the README. Instead, let's put the SGE docs in a separate Markdown file. --- Depends on: - [x] #247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These managers do not currently have a maintainer. So let's add
depwarns. If we are able to recruit a maintainer in the future, we can remove thedepwarnat that time.qsuborqrsh).qsub).condor_submit).bpsh).