Skip to content

Add depwarns (but do not remove) the managers that are not currently being maintained (SGE, PBS, HTCondor, and Scyld) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Add depwarns (but do not remove) the managers that are not currently being maintained (SGE, PBS, HTCondor, and Scyld) #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad85cb5
Add a `depwarn` for the HTCondor functionality
DilumAluthge Feb 9, 2025
d585ed7
Add a `depwarn` for the SGE and PBS functionality
DilumAluthge Feb 9, 2025
9808d41
Add a `depwarn` for the Scyld functionality
DilumAluthge Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/condor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@
end

function launch(manager::HTCManager, params::Dict, instances_arr::Array, c::Condition)
let
mgr_desc = "HTCondor"
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *

Check warning on line 57 in src/condor.jl

View check run for this annotation

Codecov / codecov/patch

src/condor.jl#L55-L57 

Added lines #L55 - L57 were not covered by tests
"We are currently looking for a new maintainer. " *
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
Base.depwarn(msg, Symbol(typeof(manager)))

Check warning on line 62 in src/condor.jl

View check run for this annotation

Codecov / codecov/patch

src/condor.jl#L62 

Added line #L62 was not covered by tests
end
try
portnum = rand(8000:9000)
portnum, server = listenany(ip"0.0.0.0", portnum)
Expand Down
19 changes: 19 additions & 0 deletions src/qsub.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@

function launch(manager::Union{PBSManager, SGEManager, QRSHManager},
params::Dict, instances_arr::Array, c::Condition)
let
if manager isa PBSManager
mgr_desc = "Portable Batch System (PBS)"
elseif manager isa SGEManager
mgr_desc = "Sun Grid Engine (SGE)"

Check warning on line 27 in src/qsub.jl

View check run for this annotation

Codecov / codecov/patch

src/qsub.jl#L23-L27 

Added lines #L23 - L27 were not covered by tests
else
# manager isa QRSHManager
#
# `qrsh` is only available for SGE.
# It is not available for OpenPBS.
mgr_desc = "Sun Grid Engine (SGE)"

Check warning on line 33 in src/qsub.jl

View check run for this annotation

Codecov / codecov/patch

src/qsub.jl#L33 

Added line #L33 was not covered by tests
end
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *

Check warning on line 35 in src/qsub.jl

View check run for this annotation

Codecov / codecov/patch

src/qsub.jl#L35 

Added line #L35 was not covered by tests
"We are currently looking for a new maintainer. " *
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
Base.depwarn(msg, Symbol(typeof(manager)))

Check warning on line 40 in src/qsub.jl

View check run for this annotation

Codecov / codecov/patch

src/qsub.jl#L40 

Added line #L40 was not covered by tests
end
try
dir = params[:dir]
exename = params[:exename]
Expand Down
9 changes: 9 additions & 0 deletions src/scyld.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@
end

function launch(manager::ScyldManager, params::Dict, instances_arr::Array, c::Condition)
let
manager_description = "Scyld ClusterWare"
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *

Check warning on line 10 in src/scyld.jl

View check run for this annotation

Codecov / codecov/patch

src/scyld.jl#L8-L10 

Added lines #L8 - L10 were not covered by tests
"We are currently looking for a new maintainer. " *
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
Base.depwarn(msg, Symbol(typeof(manager)))

Check warning on line 15 in src/scyld.jl

View check run for this annotation

Codecov / codecov/patch

src/scyld.jl#L15 

Added line #L15 was not covered by tests
end
try
dir = params[:dir]
exename = params[:exename]
Expand Down
Loading