Added complete elliptic functions for 1st and 2nd kind #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
simonbyrne
reviewed
Dec 17, 2018
|
It needs some basic tests against known values (e.g. from papers or something like Mathematica). Ideally we should test all the branches. |
simonbyrne
approved these changes
Dec 17, 2018
|
I'm happy to merge as is, but it would be good to improve the coverage stats if possible (look at the coveralls output for which lines are still missed). |
|
Okay!! |
|
DONE!! Increased Coverage by adding more tests! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computes Complete Elliptic functions E(k) and K(k) in domain [-inf,1) using piecewise approximate polynomial. Faster than all existing methods for elliptical integral computation ,(
benchmarked time = 0.021ns for 0<k<1) and quite precise as well having relative tolerance of within2*eps()in double precision case.