Fix linear indexing for 0D views of OffsetVectors #39404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
approved these changes
Jan 26, 2021
|
Juuust outside the online reviewable window is a comment that should now be removed: |
|
Eh, easier to actually do the edits than try to make that link work. Hah. |
|
I must confess I'm a little surprised this hasn't cropped up before. Unlike #39393, this hits far more code paths than just a no-index getindex. Do we have workarounds in the Offset implementations? Or are we missing some test coverage? |
|
This has been a bug in |
mbauman
added
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Fix linear indexing for views of OffsetVectors * update comments Co-authored-by: Matt Bauman <[email protected]> (cherry picked from commit f2a2637)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Fix linear indexing for views of OffsetVectors * update comments Co-authored-by: Matt Bauman <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Fix linear indexing for views of OffsetVectors * update comments Co-authored-by: Matt Bauman <[email protected]>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Fix linear indexing for views of OffsetVectors * update comments Co-authored-by: Matt Bauman <[email protected]> (cherry picked from commit f2a2637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37274 by choosing an appropriate starting linear index for
OffsetVectors using their axes.Now
This solution is inspired by #39393