Serialize zeroed-out remote refs to non-ClusterSerializer objects #22836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jul 17, 2017
test/distributed_exec.jl
Outdated
| io=IOBuffer() | ||
| serialize(io, ref) | ||
| seekstart(io) | ||
| ref2=deserialize(io) |
tkelman
reviewed
Jul 17, 2017
test/distributed_exec.jl
Outdated
| for fld in fieldnames(typeof(ref)) | ||
| v = getfield(ref2, fld) | ||
| if isa(v, Number) | ||
| @test v == zero(typeof(v)) |
Contributor
There was a problem hiding this comment.
could be === to also ensure right type
amitmurthy
force-pushed
the
amitm/22341_zeroref
branch
from
08dd659 to
d555193
Compare
Contributor
Author
|
AV error is libgit2, Travis error is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22341
See #22341 (comment)