Explicitly declare type constructor imports #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would otherwise give a warning after JuliaLang/julia#57311, but are a good change even independently.
dkarrasch
reviewed
Feb 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 91.90% 91.86% -0.04%
==========================================
Files 34 34
Lines 15371 15371
==========================================
- Hits 14126 14121 -5
- Misses 1245 1250 +5 ☔ View full report in Codecov by Sentry. |
KristofferC
pushed a commit
that referenced
this pull request
Feb 25, 2025
These would otherwise give a warning after JuliaLang/julia#57311, but are a good change even independently. --------- Co-authored-by: Daniel Karrasch <[email protected]> (cherry picked from commit 2a1696a)
KristofferC
added a commit
that referenced
this pull request
Feb 25, 2025
Backported PRs: - [x] #1194 - [x] #1207 - [x] #1196 <!-- Explicitly declare type constructor imports --> - [x] #1202 <!-- Add fast path in generic matmul --> - [x] #1203 <!-- Restrict Diagonal sqrt branch to positive diag --> - [x] #1210 <!-- Indirection in matrix multiplication to avoid ambiguities -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would otherwise give a warning after JuliaLang/julia#57311, but are a good change even independently.