Optimize BandedBlockBandedMatrix #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huanglangwen
changed the title
huanglangwen
changed the title
huanglangwen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 67.98% 70.66% +2.68%
==========================================
Files 7 7
Lines 406 450 +44
==========================================
+ Hits 276 318 +42
- Misses 130 132 +2
Continue to review full report at Codecov.
|
src/jacobians.jl
Outdated
| end | ||
| end | ||
|
|
||
| @inline function _colorediteration!(Jac::BlockBandedMatrices.BandedBlockBandedMatrix, |
There was a problem hiding this comment.
put this in an @requires block
| @require BlockBandedMatrices="ffab5731-97b5-5995-9138-79e8c1846df0" begin | ||
| _use_findstructralnz(::BlockBandedMatrices.BandedBlockBandedMatrix) = false | ||
|
|
||
| @inline function _colorediteration!(Jac::BlockBandedMatrices.BandedBlockBandedMatrix, |
There was a problem hiding this comment.
What about just standard BlockBandedMatrix and BandedMatrix? Are those fine without a special iteration?
There was a problem hiding this comment.
Yeah, I'm working on that.
ChrisRackauckas
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original indexing based assignment is slow for BandedBlockBandedMatrix compared to CSC matrix (#67). This PR switch to a column-based iteration, the evaluation time of colored jacobian for BBBmatrix is reduced from 120 ms to 87ms while the performance for CSC matrix is kept the same.