Skip to content

Conversation

@Jeroenll
Copy link
Owner

Original Pull Request

magento#16286
Invoice grid isn't updated when state is changed.

Description

Invoice updates aren't updated in a grid. Regarding our use case: We create proforma invoices with their own increment ID (e.g. Concept #1), upon shipment we update update the increment ID to use the normal invoice sequence. These changes aren't picked up by the indexer because the UpdatedAtListProvider isn't used.

Issue should be reproducible using scenarios below.

Fixed Issues (if relevant)

  1. None I could find.

Manual testing scenarios

  1. Enable async grid indexing.
  2. Create order + invoice with state open.
  3. Run the sales_grid_order_invoice_async_insert.
  4. Invoice is added to grid.
  5. Mark invoice paid.
  6. Run the sales_grid_order_invoice_async_insert.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

simpleadm and others added 30 commits March 24, 2018 21:52
magento-engcom-team and others added 20 commits June 22, 2018 09:39
…Increments\` field magento#14352

 - Merge Pull Request magento#14352 from simpleadm/magento2:fix-product-import-enable-qty-inc
 - Merged commits:
   1. 1268692
   2. 16b8b2c
   3. cb83575
Fixed issues:
 - MAGETWO-92877: Write Core Application Logs to Syslog
[arcticfoxes] MAGETWO-88814: [Performance] Some indexes become recreated on db with prefixes
Fixed issues:
- DEVOPS-2632 Sample Data Builds Migrated from Bamboo
…y UI DatePicker) with numberOfMonths = 2 or more magento#16278
Accepted Public Pull Requests:
 - magento#16278: MAGETWO-61209: Issue magento#7379 Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more (by @vasilii-b)
 - magento#16326: [Forwardport] Fixed typo error (by @vgelani)
 - magento#16321: [Forwardport] [Correct code formatting] (by @hitesh-wagento)
 - magento#16320: [Fowardport] Correct sentence in comment section in class file. (by @namratachangani)
 - magento#16245: [Forwardport 2.3] Captcha: Added integration test for checking admin login attempts cleanup (by @rogyar)
 - magento#16293: [Forwardport 2.3] Trim email address in customer account create and login form (by @dankhrapiyush)
 - magento#15812: [Forwardport] Refactored javascript code of admin notification modal popup (by @rahul-kachhadiya)
 - magento#16283: [Forwardport] DOBISSUE date format changed after customer tries to register with sa� (by @hitesh-wagento)
 - magento#14352:  Issue 14351: Product import doesn't change `Enable Qty Increments` field  (by @simpleadm)


Fixed GitHub Issues:
 - magento#7379: Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more (reported by @atihomirov) has been fixed in magento#16278 by @vasilii-b in 2.3-develop branch
   Related commits:
     1. 54e1a71
     2. e874ff0

 - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16293 by @dankhrapiyush in 2.3-develop branch
   Related commits:
     1. 89ca28f
     2. 5c1e8f7
     3. bfce026
     4. 472c141

 - magento#14351: Product import doesn't change `Enable Qty Increments` field (reported by @simpleadm) has been fixed in magento#14352 by @simpleadm in 2.3-develop branch
   Related commits:
     1. 1268692
     2. 16b8b2c
     3. cb83575
Invoice grid isn't updated when state is changed.
@Jeroenll Jeroenll closed this Jun 25, 2018
@Jeroenll Jeroenll deleted the 2.3-develop-PR-port-16286 branch July 9, 2018 07:03
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
 - Merge Pull Request magento#15797 from chirag-wagento/magento2:2.1-develop-PR-port-15789
 - Merged commits:
   1. 8bacebe
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
Accepted Public Pull Requests:
 - magento#15767: [Backport] FIX fo rissue magento#15510 - First PDF download / export after login (by @sanjay-wagento)
 - magento#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento)
 - magento#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento)
 - magento#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� magento#15 (by @chirag-wagento)
 - magento#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar)


Fixed GitHub Issues:
 - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15767 by @sanjay-wagento in 2.1-develop branch
   Related commits:
     1. 8e43c07

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15796 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. d3184ac
Jeroenll pushed a commit that referenced this pull request Nov 29, 2018
Backport [PR 18772] Remove unnecesary "header" block redeclaration
Jeroenll pushed a commit that referenced this pull request Nov 29, 2018
2.2 develop-update branch
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
Jeroenll pushed a commit that referenced this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.