Skip to content

Conversation

@Jeroenll
Copy link
Owner

Original Pull Request

magento#15089

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns magento/magento2#14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Stanislav Idolov and others added 30 commits April 14, 2018 08:03
 - Merge Pull Request magento#14711 from rossmc/magento2-1:bugfix/pdf-font-2.1-to-support-more-characters
 - Merged commits:
   1. 6165e36
Accepted Public Pull Requests:
 - magento#14680: [Backport] Checkout page - Fix tooltip position on mobile devices (by @ihor-sviziev)
 - magento#14673: [Backport] Fix issue magento#13010. Check if product is assigned to current website (by @afirlejczyk)


Fixed GitHub Issues:
 - magento#13010: Write a Review page works on multistore for products that are not assigned to that store (reported by @nuethicadam) has been fixed in magento#14673 by @afirlejczyk in 2.1-develop branch
   Related commits:
     1. 11fb821
Accepted Public Pull Requests:
 - magento#14471: magento#14465 Fix empty changelog tables after MySQL restart. (by @swnsma)


Fixed GitHub Issues:
 - magento#14465: [Indexes] Product 'version_id' lost last 'auro_increment' value after MySQL restart. (reported by @swnsma) has been fixed in magento#14471 by @swnsma in 2.1-develop branch
   Related commits:
     1. bb91de7
…le was not applied

- failed MTF test is fixed
…esent on minicart dropdown magento#14736

 - Merge Pull Request magento#14736 from Karlasa/magento2:PR-14715-backport
 - Merged commits:
   1. 493541e
… issue magento#14738

 - Merge Pull Request magento#14738 from Karlasa/magento2:PR-14716-backport
 - Merged commits:
   1. 3cc5b4d
   2. 59b2f4d
…le was not applied

- failed MTF test is fixed
Accepted Public Pull Requests:
 - magento#14711: added GNU Free Font to be used by sales PDFs (by @rossmc)


Fixed GitHub Issues:
 - magento#9666: Magento 2.1.6 - Invoice PDF doesn't support Thai (reported by @jsdupuis) has been fixed in magento#14711 by @rossmc in 2.1-develop branch
   Related commits:
     1. 6165e36

 - magento#12323: Magento 2.1.3 - Invoice and shipment PDF doesn't support Arabic (reported by @Avinashsain) has been fixed in magento#14711 by @rossmc in 2.1-develop branch
   Related commits:
     1. 6165e36
Accepted Public Pull Requests:
 - magento#14738: [backport] magento#14716 Fix - minicart label fixed size issue (by @Karlasa)
 - magento#14736: [backport] magento#14669: Css class "empty" is always present on minicart dropdown (by @Karlasa)
Fixed issues:
 - MAGETWO-89747: [Backport 2.1.x] Magento application compatible with cloud
This adds a long description to AdapterInterface::update detailing how the `$where` parameter works
…e::update magento#14770

 - Merge Pull Request magento#14770 from navarr/magento2:2.1-develop-PR-port-14755
 - Merged commits:
   1. dc7ed5c
@Jeroenll Jeroenll closed this May 23, 2018
@Jeroenll Jeroenll deleted the 2.1-develop-PR-port-15089 branch May 23, 2018 06:54
Jeroenll pushed a commit that referenced this pull request Jun 25, 2018
[Forwardport] Fixed typo mistake in function comment
Jeroenll pushed a commit that referenced this pull request Jun 25, 2018
…nto#15726

 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026
 - Merged commits:
   1. ce176d2
Jeroenll pushed a commit that referenced this pull request Jun 25, 2018
Accepted Public Pull Requests:
 - magento#16275: Simplified TypeProcessor (by @joni-jones)
 - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento)
 - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento)
 - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento)
 - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch)
 - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade)
 - magento#16256: magento#15255 unlock customer after password reset (by @vgelani)
 - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto)
 - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate)
 - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento)
 - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu)


Fixed GitHub Issues:
 - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 0f23ed7

 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 7f34b22
     2. 349d178

 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch
   Related commits:
     1. ce176d2

 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch
   Related commits:
     1. a108233
Jeroenll pushed a commit that referenced this pull request Jul 5, 2018
Jeroenll pushed a commit that referenced this pull request Jul 5, 2018
[Forwardport] When searching for the title if search for all the segments that has …
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
[Backport] Added language translation for message string
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
[Backport] [Resolved : Styling <select> by changing less variables in Luma theme…
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
Jeroenll pushed a commit that referenced this pull request Nov 29, 2018
Jeroenll pushed a commit that referenced this pull request Nov 29, 2018
Jeroenll pushed a commit that referenced this pull request Dec 10, 2018
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
Jeroenll pushed a commit that referenced this pull request Jan 3, 2019
Jeroenll pushed a commit that referenced this pull request Jan 3, 2019
Missing setTotalCount on $searchResults object in getList method
Jeroenll pushed a commit that referenced this pull request Jun 14, 2019
Jeroenll pushed a commit that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.