Skip to content

[Backport] Fix unnecessary recalculation of product list pricing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Backport] Fix unnecessary recalculation of product list pricing #2

wants to merge 1 commit into from

Conversation

@Jeroenll
Copy link
Owner

@Jeroenll Jeroenll commented May 23, 2018

Original Pull Request

magento#15089

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns magento/magento2#14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll closed this May 23, 2018
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
@ankurvr
Merge pull request #2 from magento/2.2-develop
56bcffb 
Updated Branch 2.2-develop from Magento 2 upstream
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
@sanganinamrata
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
27df0e9 
…ata\SearchResultProcessor.php #2
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
@yogeshks
Merge pull request #2 from Yogeshks/2.3-develop-PR-port-15364
c0a6b4a 
[Forwardport] Added language translation for comment tag
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
@sanganinamrata @gelanivishal
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
cb0108f 
…ata\SearchResultProcessor.php #2
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
@magento-engcom-team
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 magento#15798
18a81a8 
 - Merge Pull Request magento#15798 from chirag-wagento/magento2:2.3-develop-PR-port-15789
 - Merged commits:
   1. cd0a7b4
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 magento#15798
9ef007d
Jeroenll pushed a commit that referenced this pull request Jun 21, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
b8528ae 
Accepted Public Pull Requests:
 - magento#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri)
 - magento#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16061: Change the favicon file to the newer Magento logo (by @DMMundle)
 - magento#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf)
 - magento#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio)
 - magento#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya)
 - magento#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf)
 - magento#15798: [Forwardport] Removed unnecessary css. #2 (by @chirag-wagento)
 - magento#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento)
 - magento#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani)
 - magento#16137: FIX for apparently random API failures while using array types (by @phoenix128)


Fixed GitHub Issues:
 - magento#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento#16170 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. f53c620

 - magento#1190: installation error in  0.74.0-beta4 (reported by @sivajik34) has been fixed in magento#16153 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 2b8b9d5

 - magento#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento#15861 by @rahul-kachhadiya in 2.3-develop branch
   Related commits:
     1. 75516bf

 - magento#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento#16097 by @DanielRuf in 2.3-develop branch
   Related commits:
     1. 204b4ac

 - magento#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento#15759 by @vgelani in 2.3-develop branch
   Related commits:
     1. 61856f5
     2. 4c77dff
Jeroenll pushed a commit that referenced this pull request Jun 25, 2018
@sanganinamrata
Merge pull request #2 from NamrataChangani/2.3-develop-PR-port-15795
1a76cdb 
[Forwardport] Remove double semicolon from the style sheets.
Jeroenll pushed a commit that referenced this pull request Jul 5, 2018
@sanganinamrata
Fixed set template syntax in block file #2
86b9895
@Jeroenll Jeroenll deleted the 2.1-develop-PR-port-15089 branch July 9, 2018 07:03
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
@sanganinamrata @gelanivishal
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
3c58390 
…ata\SearchResultProcessor.php #2
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
@magento-engcom-team
ENGCOM-1962: [Backport] Resolve Error While Trying To Load Quote Item…
957b835 
… Collection Using Magent… #2 magento#15829

 - Merge Pull Request magento#15829 from neeta-wagento/magento2:2.1-develop-PR-port-11869
 - Merged commits:
   1. c261156
   2. 950e317
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
@VladimirZaets
ENGCOM-1962: [Backport] Resolve Error While Trying To Load Quote Item…
4d687fe 
… Collection Using Magent… #2 magento#15829
Jeroenll pushed a commit that referenced this pull request Jul 9, 2018
🔃 [EngCom] Public Pull Requests - 2.1-develop
1d129d7 
Accepted Public Pull Requests:
 - magento#15829: [Backport] Resolve Error While Trying To Load Quote Item Collection Using Magent� #2 (by @neeta-wagento)
 - magento#15834: [BackPort] Resolve Knockout non-unique elements id in console error (by @viral-wagento)


Fixed GitHub Issues:
 - magento#8954: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() (reported by @rendyep) has been fixed in magento#15829 by @neeta-wagento in 2.1-develop branch
   Related commits:
     1. c261156
     2. 950e317

 - magento#15348: Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" (reported by @neeta-wagento) has been fixed in magento#15834 by @viral-wagento in 2.1-develop branch
   Related commits:
     1. b63d2c5
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
@BezV8
Merge pull request #2 from magento/2.3-develop
25b40f5 
Sync to magento
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
@maximbaibakov
Merge pull request #2 from magento/2.2-develop
b1fcec4 
Sync
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
@jignesh-baldha @lewisvoncken
Removed unnecessary characters from comments #2
a48bb81
Jeroenll pushed a commit that referenced this pull request Oct 29, 2018
Merge pull request #2 from magento/2.2-develop
8c868c3 
2.2 develop
Jeroenll pushed a commit that referenced this pull request Nov 29, 2018
Merge pull request #2 from magento/2.2-develop
301d73d 
2.2 develop-update
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
@khodu
Merge pull request #2 from magento/2.3-develop
3ba9281 
merge request
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
@Dharmeshvaja91
Merge pull request #2 from magento/2.3-develop
c0d3480 
Update Magento
Jeroenll pushed a commit that referenced this pull request Dec 12, 2018
@suryakant-krish
Merge pull request #2 from magento/2.3-develop
9143820 
Branch Update
Jeroenll pushed a commit that referenced this pull request Jan 21, 2019
@niravkrish
Merge pull request #2 from magento/2.3-develop
52130ac 
Latest Magento 2.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jeroenll