Skip to content

Conversation

@chirag-wagento
Copy link
Contributor

Original Pull Request

#16002

Description

On smaller screens checkout page cart icon didn't had hover color and regular color was not implemented through correct variable. (Should be button color, not primary color)

Manual testing scenarios

  1. Go to checkout page
  2. scale screen down - to see cart icon
  3. move mouse over cart icon

Expected result

cart icon color changes

Actual result

cart icon color stays same

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 12, 2018
@orlangur orlangur self-assigned this Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2002 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants