Skip to content

chore: allow using static connection info in Connector #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

chore: allow using static connection info in Connector #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a8904
chore: allow using static connection info in Connector
rhatgadkar-goog Jul 19, 2025
2d07ca5
add test to verify connection with staticonnectioninfocache
rhatgadkar-goog Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/cloud/alloydbconnector/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
from google.cloud.alloydbconnector.instance import RefreshAheadCache
from google.cloud.alloydbconnector.lazy import LazyRefreshCache
import google.cloud.alloydbconnector.pg8000 as pg8000
from google.cloud.alloydbconnector.static import StaticConnectionInfoCache
from google.cloud.alloydbconnector.types import CacheTypes
from google.cloud.alloydbconnector.utils import generate_keys
from google.cloud.alloydbconnector.utils import strip_http_prefix
Expand Down Expand Up @@ -188,6 +189,8 @@ async def connect_async(self, instance_uri: str, driver: str, **kwargs: Any) ->
# use existing connection info if possible
if instance_uri in self._cache:
cache = self._cache[instance_uri]
elif self._static_conn_info:
cache = StaticConnectionInfoCache(instance_uri, self._static_conn_info)
else:
if self._refresh_strategy == RefreshStrategy.LAZY:
logger.debug(
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ def test_Connector_static_connection_info(
)
# check connection is returned
assert connection is True
# check that cache is not set
assert fake_client.instance.uri() not in connector._cache


def test_connect_when_closed(credentials: FakeCredentials) -> None:
Expand Down
Loading