forked from arduino/library-registry
-
Notifications
You must be signed in to change notification settings - Fork 0
update #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ButtonClickCheck : add * ButtonClickCheck : Please add a blank line to the end of the file. --------- Co-authored-by: Dang-Gun <[email protected]>
Arduino IDE I realized that it's not ready for release due to compability issues such as using vprintf.
Removing a new library I added earlier today.
Add DHT11 to the library.
Added Taskfun library
* Update repositories.txt * Update repositories.txt
Add the lib SIOT_Core_Lib
Added Eventfun library
* Update and rename repositories.txt to M304-lib * Revert inadvertent file rename --------- Co-authored-by: per1234 <[email protected]>
yfrobot fpm383 library
updating library repository
Added two new sensor libs for TMP6x and HDC302x temperature sensors. Developed by sndrschnklshk.
* Update repositories.txt * Update repositories.txt
Added RemoteSerial library v0.0.1
Submit Geekble_note2freq library
Add tedtoal/Button_TT
The goal is to make it possible for any community member to submit libraries to the registry, regardless of their level of relevant technical expertise. For this reason, the project documentation includes a detailed and comprehensive set of instructions for submitting a library. Since the time these instructions were written, a regression was introduced into the GitHub website: When creating a commit via the GitHub web interface, the dialog allows the user to select which branch the commit should be made to. Typically this includes two options: - "Commit directly to the <target branch> branch" (where "<target branch>" is the branch the user had selected when they initiated the procedure) - "Create a new branch for this commit and start a pull request" If the branch protection rules configured for the target prevent the user from committing to that branch, then the first of the options is removed (which is the appropriate behavior). Following GitHub's regression, under the conditions produced by the previous submission procedure, the determination of whether the first option should be disabled is based on the branch protection configuration of the arduino/arduino-registry repository, not of the library submitter's fork. This is incorrect because the fork does not inherit the branch protection settings of the parent, meaning the target branch will never be protected in the fork and thus that the commit to that branch should be allowed in the dialog. Because we do have branch protection rules enabled for the `main` branch of the `arduino/library-registry` repo, this bug causes the default setting in the dialog to be changed from "Commit directly to the main branch" to "Create a new branch for this commit and start a pull request" when the documented submission procedure is performed. Strangely, the user flow is significantly different depending on which of these options is selected. The user flow when "Create a new branch for this commit and start a pull request" is selected forces the user to submit the PR to their own fork repository instead of to arduino/library-registry. It is essential for the PR to be submitted to arduino/library-registry so this change in the outcome of the previous documented submission procedure as a side effect of GitHub's regression is catastrophic. The submission instructions are hereby updated to once again produce a correct submission. Unfortunately, the procedure that is now required is more complex and less intuitive than the previous one. In order to mitigate this, I made an effort to be extra explicit both in describing the actions to be performed, as well as describing the expected result of each action. I reported the regression to GitHub. I will change the documentation back to using the more friendly submission procedure once it is fixed.
added https://github.com/ripred/MyKeywords library Co-authored-by: Trent M. Wyatt <[email protected]>
Co-authored-by: Henry Abrahamsen <[email protected]>
Adjust submission procedure documentation to get correct PR base repo
Added the [TinyGPSMinus](https://github.com/EricAndrechek/TinyGPSMinus) Library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.