Skip to content

Update and rename repositories.txt to M304-lib #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

mhorimoto
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: other Something other than a library list request label Jun 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Hi @mhorimoto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 June 4, 2023 08:27
Copy link
Contributor Author

@mhorimoto mhorimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename is my mistake.
no renamed.

@per1234 per1234 self-assigned this Jun 4, 2023
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: other Something other than a library list request labels Jun 4, 2023
@github-actions github-actions bot removed the request for review from per1234 June 4, 2023 13:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/mhorimoto/M304-lib:

Linting library in M304-lib
INFO: No header file found matching library name (M304_Library.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name M304 Library contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP015)                                                                                                  
WARNING: Library name M304 Library contains "library". This is superfluous.                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: library.properties maintainer value HOLLY&Co.,Ltd. <[email protected]> contains "Arduino". 3rd party     
         libraries are not maintained by Arduino.                                                                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP057)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

@github-actions github-actions bot merged commit 3f0be5c into arduino:main Jun 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/mhorimoto/M304-lib/

github-actions bot pushed a commit that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants