Skip to content

Missing DNS callbacks #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Missing DNS callbacks #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65001d8
Removes the code that needlessly clears the DNS callback list.
Nov 20, 2024
f14d569
Fix unit tests
tony-josi-aws Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions source/FreeRTOS_IP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,15 +670,6 @@ void vIPNetworkUpCalls( struct xNetworkEndPoint * pxEndPoint )
#endif
#endif /* ipconfigUSE_NETWORK_EVENT_HOOK */

#if ( ipconfigDNS_USE_CALLBACKS != 0 )
{
/* The following function is declared in FreeRTOS_DNS.c and 'private' to
* this library */
extern void vDNSInitialise( void );
vDNSInitialise();
}
#endif /* ipconfigDNS_USE_CALLBACKS != 0 */

/* Set remaining time to 0 so it will become active immediately. */
if( pxEndPoint->bits.bIPv6 == pdTRUE_UNSIGNED )
{
Expand Down
2 changes: 0 additions & 2 deletions test/unit-test/FreeRTOS_IP/FreeRTOS_IP_utest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ void test_vIPNetworkUpCalls( void )
xEndPoint.bits.bIPv6 = pdFALSE;

vApplicationIPNetworkEventHook_Multi_Expect( eNetworkUp, &xEndPoint );
vDNSInitialise_Expect();
vARPTimerReload_Expect( pdMS_TO_TICKS( 10000 ) );

vIPNetworkUpCalls( &xEndPoint );
Expand Down Expand Up @@ -4369,7 +4368,6 @@ static void prvIPNetworkUpCalls_Generic( const uint8_t * pucAddress,
}

vApplicationIPNetworkEventHook_Multi_Expect( eNetworkUp, &xEndPoint );
vDNSInitialise_Expect();

if( xEndPoint.bits.bIPv6 == pdTRUE_UNSIGNED )
{
Expand Down
1 change: 0 additions & 1 deletion test/unit-test/FreeRTOS_IP_DiffConfig1/FreeRTOS_IP_DiffConfig1_utest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ void test_vIPNetworkUpCalls_BackwardCompatible( void )
NetworkEndPoint_t xEndPoint = { 0 };

vApplicationIPNetworkEventHook_Expect( eNetworkUp );
vDNSInitialise_Expect();
vARPTimerReload_Expect( pdMS_TO_TICKS( 10000 ) );

vIPNetworkUpCalls( &xEndPoint );
Expand Down
Loading