Missing DNS callbacks #1206
Merged
Missing DNS callbacks #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is causing DNS callbacks to not get called when the queries time out.
ActoryOu
previously approved these changes
Nov 21, 2024
ActoryOu
approved these changes
Nov 21, 2024
tony-josi-aws
approved these changes
Nov 21, 2024
aggarg
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Test Steps
Imagine that the DUT has it's network down.
User code calls
FreeRTOS_getaddrinfo_a()and supplies a callback function.If a Network-UP event happens after the call to
FreeRTOS_getaddrinfo_a()but before the query times out, the user's callback function never gets called.A colleague of mine traced that to the fact that +TCP re-initializes
xCallbackListevery time there is a Network-UP event.I believe this is incorrect behavior. I see no good reason to blindly clear
xCallbackList. This list was properly initialized already and is being managed correctly by the DNS handler and the DNS timer.I believe this is a very simple and safe fix, but as always, I may have missed something.
Let me know what you think.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.